fix sending more than 16MB <2> (#47)

* patch sending_more_than_16mbyte <2>
* add test shouldBeLongerTextThan16Mb
* test error patch

Author: kobi97

.travis.yml

@@ -32,7 +32,9 @@ before_script:
   - "echo '[mysqld]'            | sudo tee /etc/mysql/conf.d/replication.cnf"
   - "echo 'log-bin=mysql-bin'   | sudo tee -a /etc/mysql/conf.d/replication.cnf"
   - "echo 'server-id=1'         | sudo tee -a /etc/mysql/conf.d/replication.cnf"
-  - "echo 'binlog-format = row' | sudo tee -a /etc/mysql/conf.d/replication.cnf"
+  - "echo 'binlog-format= row' | sudo tee -a /etc/mysql/conf.d/replication.cnf"
+  - "echo 'max_allowed_packet= 64M' | sudo tee -a /etc/mysql/conf.d/replication.cnf"
+  - "echo 'innodb_log_file_size= 250M' | sudo tee -a /etc/mysql/conf.d/replication.cnf"
   - "cat /etc/mysql/conf.d/replication.cnf"
 
   # Enable GTID (only for mysql 5.*)

src/MySQLReplication/BinLog/BinLogSocketConnect.php

@@ -85,7 +85,7 @@ public function getResponse($checkResponse = true)
 
         $result = $this->socket->readFromSocket($dataLength);
         if (true === $checkResponse) {
-            $this->isWriteSuccessful($result, $isMaxDataLength);
+            $this->isWriteSuccessful($result);
         }
 
         //https://dev.mysql.com/doc/internals/en/sending-more-than-16mbyte.html
@@ -96,11 +96,7 @@ public function getResponse($checkResponse = true)
             }
             $dataLength = unpack('L', $header[0] . $header[1] . $header[2] . chr(0))[1];
             $isMaxDataLength = $dataLength === $this->binaryDataMaxLength;
-
             $next_result = $this->socket->readFromSocket($dataLength);
-            if (true === $checkResponse) {
-                $this->isWriteSuccessful($next_result, $isMaxDataLength);
-            }
             $result .= $next_result;
         }
 
@@ -109,15 +105,11 @@ public function getResponse($checkResponse = true)
 
     /**
      * @param string $data
-     * @param bool   $isMaxDataLength
      *
      * @throws BinLogException
      */
-    private function isWriteSuccessful($data, $isMaxDataLength = false)
+    private function isWriteSuccessful($data)
     {
-        if ($isMaxDataLength) {
-            return;
-        }
         $head = ord($data[0]);
         if (!in_array($head, $this->packageOkHeader, true)) {
             $errorCode = unpack('v', $data[1] . $data[2])[1];

tests/Integration/TypesTest.php

@@ -613,6 +613,24 @@ public function shouldBeLongBlob()
         self::assertEquals('World', $event->getValues()[0]['test2']);
     }
 
+    /**
+     * https://dev.mysql.com/doc/internals/en/mysql-packet.html
+     * https://dev.mysql.com/doc/internals/en/sending-more-than-16mbyte.html
+     * @test
+     */
+    public function shouldBeLongerTextThan16Mb()
+    {
+        $long_text_data = '';
+        for ($i = 0; $i < 40000000; $i++) {
+            $long_text_data .= 'a';
+        }
+        $create_query = "CREATE TABLE test (data LONGTEXT);";
+        $insert_query = "INSERT INTO test (data) VALUES ('{$long_text_data}')";
+        $event = $this->createAndInsertValue($create_query, $insert_query);
+
+        self::assertEquals(strlen($long_text_data), strlen($event->getValues()[0]['data']));
+    }
+
     /**
      * @test
      */
@@ -815,4 +833,4 @@ public function shouldBeJson()
         self::assertEquals('{"bool":false}', $results[26]['j']);
         self::assertEquals('{"null":null}', $results[27]['j']);
     }
-}
+}