Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.0] 이상한 네이밍 수정 #193

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

x-0o0
Copy link
Contributor

@x-0o0 x-0o0 commented Mar 28, 2024

isCompleteOnboarding -> isOnboardingCompleted 로 수정

Bool 은 be + 주어 + p.p.로 명명할 것 (의문형으로)

"Is onboarding completed?"

@x-0o0 x-0o0 requested a review from lgvv March 28, 2024 18:21
@x-0o0 x-0o0 self-assigned this Mar 28, 2024
@x-0o0 x-0o0 added v2 온보딩 온보딩 기능 labels Mar 28, 2024
@x-0o0
Copy link
Contributor Author

x-0o0 commented Mar 28, 2024

/쿠링 패키지 빌드

Copy link

🔨 iOS 17.0.1 iPhone 15 Pro 에서 스위프트 패키지를 빌드합니다.

@x-0o0 x-0o0 enabled auto-merge (squash) March 28, 2024 19:01
Copy link

✅ 패키지를 성공적으로 빌드했습니다.

@x-0o0 x-0o0 merged commit df16005 into develop/2.0.0 Mar 29, 2024
@x-0o0 x-0o0 deleted the bugfix/jaesung/fix-convention branch March 29, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 온보딩 온보딩 기능
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants