Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] move feedback package #109

Merged
merged 6 commits into from
Jan 9, 2024

Conversation

zbqmgldjfh
Copy link
Member

변경 사항

  1. 기존의 Feedback 페키지를 User 도메인 하부로 이동시킨다.
  2. Feedback의 content를 값객체로 구현한다.

@zbqmgldjfh zbqmgldjfh self-assigned this Jan 9, 2024
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
86.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@zbqmgldjfh zbqmgldjfh merged commit fd554a0 into develop Jan 9, 2024
2 checks passed
@zbqmgldjfh zbqmgldjfh deleted the refactor/move-feedback-package-#92 branch January 9, 2024 11:18
zbqmgldjfh added a commit that referenced this pull request Jan 17, 2024
* refactor(Feedback): Feedback 페키지를 User 하부로 이동

* refactor(Content): Feedback의 본문 내용인 Content 를 값객체로 리팩토링

* test(Feedback): 피드백 도메인 테스트 작성

* test(FeedbackTest): 피드백 동등성 테스트 작성

* test(FeedbackTest): 접근제어자 제거

* test(FeedbackTest):clear_all_feedback 에서 사이즈를 확인하는 단언문을 hasSize를 사용하도록 변경
zbqmgldjfh added a commit that referenced this pull request Jan 21, 2024
* refactor(Feedback): Feedback 페키지를 User 하부로 이동

* refactor(Content): Feedback의 본문 내용인 Content 를 값객체로 리팩토링

* test(Feedback): 피드백 도메인 테스트 작성

* test(FeedbackTest): 피드백 동등성 테스트 작성

* test(FeedbackTest): 접근제어자 제거

* test(FeedbackTest):clear_all_feedback 에서 사이즈를 확인하는 단언문을 hasSize를 사용하도록 변경
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant