Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] user refactor #111

Merged
merged 5 commits into from
Jan 12, 2024
Merged

[Refactor] user refactor #111

merged 5 commits into from
Jan 12, 2024

Conversation

zbqmgldjfh
Copy link
Member

close #110

TODO

  1. URL 부분 검증 pattern 변경, pattern 정적으로 미리 컴파일 해두기
  2. User ID의 Getter 제거
  3. User에 Repository + 조회 전용 QueryDsl 로 변경
  4. readme 정렬

Copy link

sonarqubecloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

12 New issues
0 Security Hotspots
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@zbqmgldjfh zbqmgldjfh merged commit 96e30c2 into develop Jan 12, 2024
2 checks passed
@zbqmgldjfh zbqmgldjfh deleted the refactor/user-refactor-#110 branch January 17, 2024 07:14
zbqmgldjfh added a commit that referenced this pull request Jan 17, 2024
* feat(User): User의 Id에 private getter 제거

* feat(Url): Url의 pattern 변경과 상수로 미리 compile해 두도록 변경

* feat(UserQueryRepository): User 에그리거트에 하나의 repository만 만들어 사용하도록 변경

* docs(Readme): 리드미 일부 수정

* refactor(Notice): 생성자의 파라미터에 개행 추가
zbqmgldjfh added a commit that referenced this pull request Jan 21, 2024
* feat(User): User의 Id에 private getter 제거

* feat(Url): Url의 pattern 변경과 상수로 미리 compile해 두도록 변경

* feat(UserQueryRepository): User 에그리거트에 하나의 repository만 만들어 사용하도록 변경

* docs(Readme): 리드미 일부 수정

* refactor(Notice): 생성자의 파라미터에 개행 추가
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant