version 2.6.1 #145
Merged
version 2.6.1 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(Staff): 도메인 리팩토링 * refactor(Staff): Name필드 값객체로 리팩토링 * refactor(StaffUpdater): 코드단위를 의미있는 함수로 나누어서 추상화 수준을 올린다 이전 코드는 너무 구현부를 읽어야만 이해할 수 있었던 코드였다. 이를 리팩토링하여 의미있는 메서드로 분리하고, 더 나아가 다른 팀원이 추상화된 수준에서 코드의 흐름을 읽을 수 있도록 리팩토링 한다 * refactor(EachDeptStaffApiClient): ApiClient 리팩토링 * refactor(KuStaffApiClient): ApiClient 리팩토링 * refactor(RealEstateStaffApiClient): ApiClient 리팩토링 * refactor: Dto 패키지를 상위로 이동 update, scrap 둘다에서 공통적으로 사용중이라 상위 패키지로 이동한다 * refactor(UserUpdater): UserUpdater 로직을 500건 씩 수행하도록 변경 * refactor(RealEstateNoticeHtmlParser): RealEstateNoticeHtmlParser 리팩토링 * feat(HtmlParser): 사용하지 않는 인터페이스 제거 * refactor(NoticeHtmlParserTemplate): 공통의 기능을 포괄하고 있는 ParserTemplate 구현 완료 * test(LivingAndCommunicationDesignStaffHtmlParser): 공지 파싱 테스트 작성 * feat(StaffHtmlParserTemplate): 교직원 정보를 파싱하는 StaffHtmlParserTemplate 구현 * refactor(StaffScraper): StaffScraper 리팩토링 * refactor: 테스트 코드에서 public 지정자 제거 * feat(StaffDataSynchronizer): 동기화 하는 서비스를 따로 분리하여 구현한다 * refactor(User): 엔티티에 column 명시해주기 * fix(EachDeptStaffApiClient): 잘못된 반복문 수정
|
Unit Test Results 38 files + 4 38 suites +4 29s ⏱️ ±0s Results for commit bdc3bed. ± Comparison against base commit 0def313. This pull request removes 2 and adds 51 tests. Note that renamed tests count towards both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
공지 url 변경으로 인한 bug fix