Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Update homepage notice #140 #146

Merged
merged 8 commits into from
Feb 26, 2024

Conversation

zbqmgldjfh
Copy link
Member

TODO

학과별 공지 스크랩 로직 빠른 개편
향후 JPA를 사용하도록 변경 예정

@zbqmgldjfh zbqmgldjfh added 🐛 Bug Something isn't working ⭐ Feat labels Feb 26, 2024
@zbqmgldjfh zbqmgldjfh self-assigned this Feb 26, 2024
Copy link

Copy link

Unit Test Results

  39 files  +1    39 suites  +1   30s ⏱️ -1s
193 tests +2  193 ✔️ +2  0 💤 ±0  0 ±0 
196 runs  +2  196 ✔️ +2  0 💤 ±0  0 ±0 

Results for commit 62b3308. ± Comparison against base commit 74083ed.

@zbqmgldjfh zbqmgldjfh merged commit c5f5ff9 into develop Feb 26, 2024
4 checks passed
@zbqmgldjfh zbqmgldjfh deleted the feat/update-homepage-notice-#140 branch February 26, 2024 05:22
zbqmgldjfh added a commit that referenced this pull request Feb 27, 2024
* test: getTotalNoticeSize 메서드 단위 테스트

* feat: 학과별 정보 수정

* feat: 학과별 공지 스크랩 로직 수정

* fix(DeptInfo#createViewUrl): 정상적으로 view Url을 만들지 못하던 문제 해결

* refactor(CategoryNoticeUpdater): updateKuisNoticeAsync에서 reverse로직 추가

* refactor: 시간 측정 로직 변경

* feat: 기존 학과별 공지 삭제 DDL문 작성

* test: 테스트에서 변경 가능한 리스트를 반환하도록 수정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working ⭐ Feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant