Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Config divide #148

Merged
merged 3 commits into from
Mar 2, 2024
Merged

[Refactor] Config divide #148

merged 3 commits into from
Mar 2, 2024

Conversation

zbqmgldjfh
Copy link
Member

TODO

  1. 환경변수 분리
  2. 스크립트에 힙메모리 제한 인자와 환경파일 설정 추가
  3. 테스트 일부 수정

@zbqmgldjfh zbqmgldjfh self-assigned this Mar 2, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

Unit Test Results

  37 files  +  37    37 suites  +37   36s ⏱️ +36s
191 tests +191  182 ✔️ +182  9 💤 +9  0 ❌ ±0 
194 runs  +194  185 ✔️ +185  9 💤 +9  0 ❌ ±0 

Results for commit e1b6eb8. ± Comparison against base commit 09afebf.

@zbqmgldjfh zbqmgldjfh merged commit b3bfaff into develop Mar 2, 2024
4 checks passed
zbqmgldjfh added a commit that referenced this pull request Mar 5, 2024
@zbqmgldjfh
[Refactor] Config divide (#148)
37445b4 
* test: 테스트 리팩토링

* setting: 환경변수 파일을 환경별로 분리

test, prod, dev로 구분

* feat(start.sh): 시작 스크립트 파일에 환경파일 언급 추가와 heap메모리 제한 추가
@zbqmgldjfh zbqmgldjfh deleted the refactor/config-divide branch July 15, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zbqmgldjfh zbqmgldjfh

Labels
⭐ Feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zbqmgldjfh