updates from validation review

pkg/operator/validation.go

@@ -46,8 +46,6 @@ func IsValidListenConfig(cfg *Config) error {
 	errs := []error{}
 
 	errs = append(errs, isValidHostPort(cfg.APIListen, "apiListen"))
-	errs = append(errs, isValidHostPort(cfg.MetricsListen, "metricsListen"))
-	errs = append(errs, isValidHostPort(cfg.PprofListen, "pprofListen"))
 
 	if len(errs) > 0 {
 		return errors.NewAggregate(errs)
@@ -59,8 +57,6 @@ func IsValidListenConfig(cfg *Config) error {
 func IsValidPrestoConfig(cfg *Config) error {
 	errs := []error{}
 
-	errs = append(errs, isValidHostPort(cfg.PrestoHost, "prestoHost"))
-
 	if !cfg.PrestoUseTLS {
 		if cfg.PrestoUseClientCertAuth {
 			errs = append(errs, fmt.Errorf("prestoUseClientCertAuth cannot be set to true if prestoUseTLS is false"))
@@ -92,8 +88,6 @@ func IsValidPrestoConfig(cfg *Config) error {
 func IsValidHiveConfig(cfg *Config) error {
 	errs := []error{}
 
-	errs = append(errs, isValidHostPort(cfg.HiveHost, "hiveHost"))
-
 	if !cfg.HiveUseTLS {
 		if cfg.HiveUseClientCertAuth {
 			errs = append(errs, fmt.Errorf("hiveUseClientCertAuth cannot be set to true if hiveUseTLS is false"))

pkg/operator/validation_test.go

@@ -27,8 +27,6 @@ func TestIsValidConfig(t *testing.T) {
 			makeCfg: func() *Config {
 				cfg := validConfig()
 				cfg.APIListen = "foo:8080"
-				cfg.MetricsListen = "foo:443"
-				cfg.PprofListen = ":8080"
 				return cfg
 			},
 		},
@@ -40,22 +38,6 @@ func TestIsValidConfig(t *testing.T) {
 			},
 			expectedErr: "invalid apiListen",
 		},
-		"listen config - invalid metrics listen": {
-			makeCfg: func() *Config {
-				cfg := validConfig()
-				cfg.MetricsListen = "foo"
-				return cfg
-			},
-			expectedErr: "invalid metricsListen",
-		},
-		"listen config - invalid pprof listen": {
-			makeCfg: func() *Config {
-				cfg := validConfig()
-				cfg.PprofListen = "foo"
-				return cfg
-			},
-			expectedErr: "invalid pprofListen",
-		},
 		"presto config - valid": {
 			makeCfg: func() *Config {
 				cfg := validConfig()