Skip to content

[helm-chart] allow setting revisionHistoryLimit for webhook Certificate #4228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

[helm-chart] allow setting revisionHistoryLimit for webhook Certificate #4228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm/aws-load-balancer-controller/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: aws-load-balancer-controller
description: AWS Load Balancer Controller Helm chart for Kubernetes
version: 1.13.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to do this.

version: 1.13.3
appVersion: v2.13.2
home: https://github.com/aws/eks-charts
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
Expand Down
3 changes: 3 additions & 0 deletions helm/aws-load-balancer-controller/templates/webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,9 @@ spec:
{{- if .renewBefore }}
renewBefore: {{ .renewBefore }}
{{- end }}
{{- if .revisionHistoryLimit }}
revisionHistoryLimit: {{ .revisionHistoryLimit }}
{{- end }}
{{- end }}
---
apiVersion: cert-manager.io/v1
Expand Down
1 change: 1 addition & 0 deletions helm/aws-load-balancer-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ enableCertManager: false
certManager:
duration:
renewBefore:
revisionHistoryLimit:

# The name of the Kubernetes cluster. A non-empty value is required
clusterName:
Expand Down