WIP: Adding GCPMachinePool Functionality (continued)

[justinsb]

This is a continuation of the work started (and primarily done) by @BrennenMM7 in #901. I hope to be able to rebase it and fix up any remaining issues.

• Adding GCPMachinePool Functionality

• make generate-manifests

• Update controller for new controller-runtime

• MetadataItem: key cannot be optional

• Tweak error message

[k8s-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name	Link
🔨 Latest commit	d4d7e5d
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-cluster-api-gcp/deploys/682f74e4b34bed000824d3cd
😎 Deploy Preview	https://deploy-preview-1478--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@justinsb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-gcp-test	d4d7e5d	link	true	/test pull-cluster-api-provider-gcp-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[justinsb]

When I looked at #901 previously I thought there were three things that I thought maybe we should address or split out:

1. Should we drain? Adding GCPMachinePool Functionality #901 (comment)
2. Should GCPMachinePoolMachine just be a GCPMachine? Adding GCPMachinePool Functionality #901 (comment)
3. Do we want to address the kubeadm dependency here vs splitting it out in another PR? (I personally very much want to loosen the coupling, but I feel like maybe it is a separate PR): Adding GCPMachinePool Functionality #901 (comment)

[salasberryfin]

We should let users select the bootstrap provider of their choice. This dependency used to exist in other infrastructure providers (e.g. Azure) but it is now removed https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/4931/files#diff-090609f25d4709ca183257330305b845613ce137e49ce1f6c71512e338607bff

[damdo]

+1

[salasberryfin]

Sorry @justinsb. I just saw your comment on the original PR (should've checked first). You can resolve this if we're addressing this in a follow-up. I just want this issue to be visible.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.