🐛 Search by either port ID or name/network

[sagarun]

When port ID is available we should just search by the ID and not combine name and network of the port.

What this PR does / why we need it:
When we have Port ID available we should just search using the Port ID. This is more efficient and avoids issues when port are renamed.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2576

TODOs:

• squashed commits
• if necessary:
  • includes documentation
  • adds unit tests

/hold

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: sagarun / name: Arun S A G (1f0c734)

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	1f0c734
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/684ba5781055f80008180848
😎 Deploy Preview	https://deploy-preview-2583--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[k8s-ci-robot]

Welcome @sagarun!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @sagarun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lentzi90]

Thanks for the PR and the issue!
/ok-to-test
/lgtm

[lentzi90]

Oh, you need to define opts at the top of the function.

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[lentzi90]

Thanks!
The test failure is now unrelated (see #2590). I'll try to get that fixed and then we can merge this.
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lentzi90]

/retest

[lentzi90]

Ok now we have a real test failure. This test needs to be adapted from what I understand. The mocking is no longer correct.

[lentzi90]

Thanks! I think this is ready to take in now
/hold cancel
/cc @EmilienM