Skip to content

Add Istio report for 1.3.0 #3808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

Add Istio report for 1.3.0 #3808

merged 1 commit into from
Jun 6, 2025

Conversation

keithmattix
Copy link
Contributor

What type of PR is this?

/kind documentation
What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 21, 2025
@robscott
Copy link
Member

robscott commented May 23, 2025 •
edited
Loading

@keithmattix don't forget to update the v1.3 conformance table (#3810) when/as this PR merges

@keithmattix keithmattix force-pushed the 1-3-conformance-istio branch from 70a021e to bb10051 Compare May 26, 2025 00:21
@keithmattix
Add Istio report for 1.3.0
057d70e 
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@keithmattix keithmattix force-pushed the 1-3-conformance-istio branch from 7c9caa5 to 057d70e Compare June 5, 2025 16:27
LiorLieberman
LiorLieberman approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

Are the site-src changes intentional?

/approve

site-src/implementations/v1.1.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this an international change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran make build-docs and it generated these changes (and the markdown ones). Not sure if there's a tools versioning issue at work here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack. I think thats fine

LiorLieberman
LiorLieberman reviewed Jun 5, 2025
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

though I probably not have the right power to approve site-src/ changes

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2025
@LiorLieberman
Copy link
Member

/assign @mlavacca

@robscott
Copy link
Member

robscott commented Jun 6, 2025

Thanks @keithmattix!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: keithmattix, LiorLieberman, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit b3e0aa9 into kubernetes-sigs:main Jun 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiorLieberman LiorLieberman LiorLieberman approved these changes

@mikemorris mikemorris Awaiting requested review from mikemorris

@sunjayBhatia sunjayBhatia Awaiting requested review from sunjayBhatia

@candita candita Awaiting requested review from candita

Assignees

@mlavacca mlavacca

@LiorLieberman LiorLieberman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@keithmattix @robscott @LiorLieberman @k8s-ci-robot @mikemorris @candita @mlavacca