Skip to content

GEP 91: Update Goals and Prior Art #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

GEP 91: Update Goals and Prior Art #3838

wants to merge 4 commits into from

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Jun 6, 2025

Relates to #3760 (comment)

Will update the API in a follow up PR

/kind gep

@arkodg
GEP 91: Update Goals and Prior Art
18b1b58 
Relates to kubernetes-sigs#3760 (comment)

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@k8s-ci-robot k8s-ci-robot added kind/gep PRs related to Gateway Enhancement Proposal(GEP) do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 6, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 6, 2025
@arkodg
fix table
c690fe9 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this pull request Jun 6, 2025
Open
shaneutt
shaneutt reviewed Jun 6, 2025
View reviewed changes
geps/gep-91/index.md

## Goals

* Define an API field to specify the CA Certificate within the Gateway Listener configuration that can be used as a trust anchor to validate the certificates presented by the client. This use case has been highlighted in the [TLS Configuration GEP][] under segment 1 and in the [Gateway API TLS Use Cases][] document under point 7.
* Define an API field to specify the CA Certificate within the Gateway configuration that can be used as a trust anchor to validate the certificates presented by the client.
This use case has been highlighted in the [TLS Configuration GEP][] under segment 1 and in the [Gateway API TLS Use Cases][] document under point 7.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix these links while we're here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all these links work for me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://gateway-api.sigs.k8s.io/geps/gep-91/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't seen this link syntax before, that's probably where the confusion comes from. (the links are in the Reference section at the end.)

@kl52752
Copy link
Contributor

kl52752 commented Jun 13, 2025

Thanks for updating this GEP, LGTM :)

@arkodg
Copy link
Contributor Author

arkodg commented Jun 16, 2025

ptal @robscott @youngnick

@youngnick
Copy link
Contributor

LGTM once the table is moved, with the caveat that I really want to see the API changes move the config out of the Listener level.

robscott
robscott approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arkodg! LGTM once implementation details/prior art are moved to bottom as suggested in https://github.com/kubernetes-sigs/gateway-api/pull/3838/files#r2132259700

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2025
@robscott
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 16, 2025
arkodg added 2 commits June 15, 2025 22:27
@arkodg
moves prior art to the end of the file
4311be3 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg
rewrite prior art section description
44a2b48 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt left review comments

@robscott robscott robscott approved these changes

@mikemorris mikemorris Awaiting requested review from mikemorris

@youngnick youngnick Awaiting requested review from youngnick

@mlavacca mlavacca Awaiting requested review from mlavacca

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arkodg @kl52752 @youngnick @k8s-ci-robot @robscott @shaneutt