generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 551
Improve distribution tests in conformance for MeshHTTPRouteWeight #3855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carsontham
wants to merge
6
commits into
kubernetes-sigs:main
Choose a base branch
from
carsontham:add-entropy-to-mesh-weight-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+59
−1
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
65f128d
added entropy to mesh weight test
carsontham f056dd5
added nolint:gosec to skip linter issues for conformance test
carsontham 812f3db
move creation of header map to entropy func to avoid concurrent map w…
carsontham 3097960
use crypto/rand instead of math/rand
carsontham a0428a1
handle error checking and add default in switch
carsontham d524e19
return error in default for switch case
carsontham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this no lint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that earlier before adding the no lint, prow test was failing here due to:
G404: Use of weak random number generator (math/rand or math/rand/v2 instead of crypto/rand) (gosec)
so i followed a similar example here, to ignore linter for testing purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe using crypto.rand would make it happy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed! slightly lengthier due to error handling 😃
also re-ran the tests after using crypto.rand, attaching the new output test logs here:
MeshHTTPRouteWeight_updated.log