-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Add Auto-Labeling of Issues Based on OS Selection #11880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @aman4433! |
Hi @aman4433. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/label ci-short |
/ok-to-test |
61f4eac
to
6d755f2
Compare
Do we want to only supported OS in the choices array ? I wouldn't use this as a "List of supported OS", it's mainly to help us with categorization and stats. I don't have a strong opinion, though |
6d755f2
to
af4cfca
Compare
I don't know if it's possible to do something like Label with just the system (e.g., Ubuntu, Debian, etc.), but with system + version (e.g., Ubuntu 24.04, Debian 12, etc.) in the text. |
Would help to have a label "supported OS" could help to focus time. Or with the OS label:
|
Yes, but I'd say that better done in another PR, to keep this one simple.
|
can't it just be added in the OS label directly ? Anything to be done to enable github actions ? |
I'd rather have a separate label, since what's supported changes over time.
|
af4cfca
to
1111ead
Compare
…rkflow to auto lable
1111ead
to
24519b6
Compare
Hi everyone, I’ve made the requested changes and committed them. Let me know if you have any feedback or if there are any changes you’d like me to make. Thanks in advance! |
/approve
Looks good enough for me, we can iterate on that. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aman4433, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR introduces an automatic labeling mechanism based on the operating system (OS) specified in bug reports.
The primary objective is to capture and label the user's OS when an issue is raised. This enables aggregation and analysis of user data, helping us better understand the distribution of OS usage among our users.
Which issue(s) this PR fixes:
Fixes #11873
Special notes for your reviewer:
The OS field in the bug-report issue form has been converted into a dropdown menu for consistency and ease of selection. The list of supported OS options has been sourced from Kubespray's preinstall defaults.
A GitHub Action workflow for advanced issue labeling has been introduced. This workflow auto-assigns an OS label based on the OS selected in the bug report.
The implementation leverages the Advanced Issue Labeler GitHub Action, as described in the #11873 issue.
Your review and feedback on the OS dropdown implementation and the GitHub Action integration would be greatly appreciated!
Does this PR introduce a user-facing change?: