-
Notifications
You must be signed in to change notification settings - Fork 6.6k
fix crio restart while switching runtime #12005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mahendra77024 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @mahendra77024! |
Hi @mahendra77024. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
What this PR does / why we need it:
This PR stops the kubelet service if running, stops running containers, and then stops the crio service before changing the runtime (e.g., runc to crun). After making the changes, it starts the crio and kubelet services.
Which issue(s) this PR fixes:
Fixes # #11907
Special notes for your reviewer:
Kubernetes has changed the default runtime for CRI-O from runc to crun starting with version 1.31. This change has caused upgrade failures because CRI-O cannot handle a real-time runtime switch. As mentioned in cri-o/cri-o#8705 (comment), when switching runtimes, we need to ensure that the kubelet service and running containers are stopped before making the change.
Does this PR introduce a user-facing change?: N/A