-
Notifications
You must be signed in to change notification settings - Fork 6.7k
docs(operations): remove outdated instructions on refreshing facts cache for nodes #12127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: farshadasadpour The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @farshadasadpour. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/label ci-short |
I'm not sure what make you say that. Unless something has changed recently, you do need to run an "unlimited" |
/hold |
Hi @VannTen Thank you for pointing this out! I now understand your reasoning. The recommendation to run I’ll revisit my assumption and look deeper into this behavior to confirm how the cached facts impact subsequent playbooks like |
I’ve identified two possible approaches to resolve the issue:
Which option do you think is better? Personally, I lean toward option 1 (clarifying documentation) because it avoids changing the repository structure, but I’m open to your thoughts! |
I would go for option 2, sinds that is the same for the other playbooks as well. |
Thanks for the work, we've gone with #12177 instead |
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #12100
Special notes for your reviewer:
The current documentation advises users to run
facts.yml
separately to refresh the facts cache before using the--limit
option withscale.yml
. However, this step is unnecessary becausescale.yml
already includesfacts.yml
as part of its execution.Specifically:
scale.yml
, line 5 explicitly importsfacts.yml
Gather facts :This ensures that the facts cache is refreshed for all nodes automatically when running scale.yml, even if the --limit option is used.
By removing this redundant step from the documentation, we can simplify the instructions and prevent confusion for users, ensuring the documentation reflects the actual behavior of scale.yml.
Does this PR introduce a user-facing change?: