Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump github.com/go-git/go-git/v5 from 5.11.0 to 5.13.0 in /hack #5849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump github.com/go-git/go-git/v5 from 5.11.0 to 5.13.0 in /hack #5849

wants to merge 1 commit into from

Conversation

stormqueen1990
Copy link
Member

  • Bump the version of go-git/v5 from 5.11.0 to 5.13.0 in the /hack folder.
  • Run make workspace-sync to synchronize the workspace dependencies.

Supersedes #5848

/cc @koba1t @varshaprasad96

@stormqueen1990
Bump github.com/go-git/go-git/v5 from 5.11.0 to 5.13.0 in /hack
dfdf5b2 
* Bump the version of go-git/v5 from 5.11.0 to 5.13.0 in the /hack folder.
* Run `make workspace-sync` to synchronize the workspace dependencies.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stormqueen1990
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 17, 2025
@stormqueen1990 stormqueen1990 mentioned this pull request Jan 17, 2025
Closed
koba1t
koba1t reviewed Jan 24, 2025
View reviewed changes
api/go.mod
@@ -25,7 +25,7 @@ require (
github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00 // indirect
github.com/pkg/errors v0.9.1 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/sergi/go-diff v1.2.0 // indirect
github.com/sergi/go-diff v1.3.2-0.20230802210424-5b0b94c5c0d3 // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This non tag dependency was introduced by the new github.com/go-git/go-git pkg.
https://github.com/go-git/go-git/blob/v5.13.2/go.mod#L21

A non-tag dependency was introduced for pkg by fixing the bug.
go-git/go-git#254

I found a new release request to go-diff, but I can't find any response from the owner.
sergi/go-diff#144

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left a thumbs-up in the issue too to show community support.

@stormqueen1990
Copy link
Member Author

/hold
while we wait for sergi/go-diff#144

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba1t koba1t koba1t left review comments

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stormqueen1990 @k8s-ci-robot @koba1t