Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceptable_codes to plan.run_sh and plan.exec #2649

Open
tedim52 opened this issue Feb 7, 2025 · 2 comments
Open

Add acceptable_codes to plan.run_sh and plan.exec #2649

tedim52 opened this issue Feb 7, 2025 · 2 comments
Labels

Comments

@tedim52
Copy link
Contributor

tedim52 commented Feb 7, 2025

Background & motivation

plan.exec has an acceptable_codes field that fails the starlark script if one of the acceptable_codes isn't set.

Desired behaviour

plan.run_sh and plan.run_python should have the field on it.

How important is this to you?

Painful; the lack of this feature makes using Kurtosis frictionful.

What area of the product does this pertain to?

Other: anything not covered by the above

@tedim52
Copy link
Contributor Author

tedim52 commented Feb 7, 2025

cc. @samlaf

@github-actions github-actions bot added the painful Painful bug label Feb 7, 2025
@samlaf
Copy link
Contributor

samlaf commented Feb 9, 2025

Not familiar at all with the kurtosis codebase, but just looking at

if createDefaultDirectoryResult.GetExitCode() != 0 {
doesn't this check for a non-zero error code and return an error? Maybe the error is not handled properly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants