concurrency access on the mempool from txquery and recheckTxs

core/types/transaction.go

@@ -65,6 +65,10 @@ func (t *Transaction) Hash() Hash {
 	return HashBytes(raw)
 }
 
+func (t *Transaction) String() string {
+	return fmt.Sprintf("Tx{Hash: %X, Sender: %X, Nonce: %d, PayloadType: %s}", t.Hash(), t.Sender, t.Body.Nonce, t.Body.PayloadType)
+}
+
 // TransactionBody is the body of a transaction that gets included in the
 // signature. This type implements json.Marshaler and json.Unmarshaler to ensure
 // that the Fee field is represented as a string in JSON rather than a number.

node/mempool/mempool.go

@@ -194,8 +194,8 @@ type CheckFn func(ctx context.Context, tx *ktypes.Transaction) error
 // RecheckTxs validates all transactions in the mempool using the provided check function,
 // removing any that fail validation.
 func (mp *Mempool) RecheckTxs(ctx context.Context, fn CheckFn) {
-	mp.mtx.RLock()
-	defer mp.mtx.RUnlock()
+	mp.mtx.Lock()
+	defer mp.mtx.Unlock()
 
 	for hash, tx := range mp.txns {
 		if err := fn(ctx, tx.Transaction); err != nil {