server,cometbft: ensure app height < chain height #1066
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check in the node's db provider constructor to ensure app height is less than node blockstore height.
We already had this:
But it's extremely confusing. So, rather than wait for cometbft to begin replaying blocks, which is when it finds out about the invalid application state, we can give a clearer error with a possible resolution:
Error: panic while building kwild: failed to build comet node: failed to create CometBFT node: application (postgresql) height is past blockchain database -- drop postgresql to proceed
.However, this was a quick fix, and I want to reconsider this. Open to suggestions for a better resolution.