Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pg: avoid hang on orphaned transcation panic #1123

Merged
merged 1 commit into from
Dec 6, 2024
+10 −0
Merged

pg: avoid hang on orphaned transcation panic #1123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions node/pg/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,16 @@ func (db *DB) EnsureFullReplicaIdentityDatasets(ctx context.Context) error {
func (db *DB) Close() error {
db.cancel(nil)
db.repl.stop()
if db.tx != nil {
// This is a bug, so we are going to panic so the issue is not easily
// ignored, but we will rollback the tx so we don't hang or leak
// postgresql resources.
db.tx.Rollback(context.Background())
db.tx = nil
db.txid = ""
db.pool.Close()
panic("Closed the DB with an active transaction!")
}
return db.pool.Close()
}

Expand Down
Loading