Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CE clean shutdown fixes #1130

Merged
merged 2 commits into from
Dec 6, 2024
Merged

CE clean shutdown fixes #1130

merged 2 commits into from
Dec 6, 2024

Conversation

charithabandi
Copy link
Contributor

No description provided.

@charithabandi charithabandi force-pushed the engine-shutdown branch 2 times, most recently from 40264fa to 3599d62 Compare December 6, 2024 22:02
@charithabandi charithabandi marked this pull request as draft December 6, 2024 22:07
@charithabandi charithabandi marked this pull request as ready for review December 6, 2024 22:51
Copy link
Member

@jchappelow jchappelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that was a nice iteration. I think CI will like it too.

@jchappelow
Copy link
Member

Merge when ready!

@charithabandi charithabandi merged commit 022e5cc into main Dec 6, 2024
4 checks passed
@charithabandi charithabandi deleted the engine-shutdown branch December 6, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants