Rollback support to preemptively cancel and rollback current block ex… #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charithabandi
force-pushed
the
resetState
branch
from
30d63ca to
c2a4406
Compare
This was
linked to
issues
Dec 12, 2024
Closed
charithabandi
force-pushed
the
resetState
branch
from
f9fc75b to
0147958
Compare
jchappelow
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ecution
yet to add
kwil-admincommand to issue cancellation request and block execution status request. But rest is good.Added support for leader to manually trigger block cancellation and also provide a list of long running transactions to be purged from the mempool and re-propose a block for the same height.
Leader upon receiving this cancellation request will broadcast the resetState messages to all the validators, who upon receiving the resetMsg will stop the block execution and rollback the state.
If leader has already executed the transactions by the time we receive the cancellation request, should we still reject the current block and propose a new block or should it just ignore the request? Right now I am ignoring, but can be changed.