Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable sorts transactions in the block in nonce order, enforce consen… #1156

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

charithabandi
Copy link
Contributor

@charithabandi charithabandi commented Dec 13, 2024

…sus limits, induce voteBody and voteID transactions

Support for the following things have been added in this PR:

  • Ability to configure and run extensions
  • Order Block transactions in nonce order and enforce consensus limits such as maxBlockSz, maxVotesPerTx
  • Leader to induce ValidatorVoteBodies Tx if there are any events without resolutions
  • Validators can broadcast their vote for the existing resolutions
  • ethDeposits extension

@charithabandi charithabandi marked this pull request as draft December 13, 2024 15:19
@charithabandi charithabandi marked this pull request as ready for review December 13, 2024 16:27
@jchappelow jchappelow self-requested a review December 13, 2024 18:00
Copy link
Member

@jchappelow jchappelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash or not as desired and merge when ready. Thanks for addressing the in-place tx sort issue.

Ability to configure and run extensions
Order Block transactions in nonce order and enforce consensus limits such as maxBlockSz, maxVotesPerTx
Leader to induce ValidatorVoteBodies Tx if there are any events without resolutions
Validators can broadcast their vote for the existing resolutions
ethDeposits extension
@charithabandi charithabandi merged commit 72577a0 into kwilteam:main Dec 13, 2024
2 checks passed
@charithabandi charithabandi linked an issue Dec 13, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bring back event listeners / validator vote ID broadcast
2 participants