-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stable sorts transactions in the block in nonce order, enforce consen… #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d7309f
to
c89986c
Compare
5225cac
to
eac8b07
Compare
jchappelow
reviewed
Dec 13, 2024
eac8b07
to
45d3455
Compare
jchappelow
reviewed
Dec 13, 2024
45d3455
to
34f442a
Compare
jchappelow
reviewed
Dec 13, 2024
34f442a
to
20c4a45
Compare
jchappelow
reviewed
Dec 13, 2024
jchappelow
reviewed
Dec 13, 2024
20c4a45
to
94b78e3
Compare
jchappelow
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please squash or not as desired and merge when ready. Thanks for addressing the in-place tx sort issue.
Ability to configure and run extensions Order Block transactions in nonce order and enforce consensus limits such as maxBlockSz, maxVotesPerTx Leader to induce ValidatorVoteBodies Tx if there are any events without resolutions Validators can broadcast their vote for the existing resolutions ethDeposits extension
94b78e3
to
c0bfdb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sus limits, induce voteBody and voteID transactions
Support for the following things have been added in this PR: