structured tx in block #1172
Merged
structured tx in block #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jchappelow
commented
Dec 18, 2024
•
jchappelow
commented
jchappelow
force-pushed
the
block-txn-strucutre
branch
from
b63430d to
a5fa765
Compare
jchappelow
commented
Dec 19, 2024
jchappelow
commented
Dec 19, 2024
| @@ -11,7 +11,7 @@ type blockExecStatus struct { | |||
| startTime, endTime time.Time | |||
| height int64 | |||
| txIDs []ktypes.Hash | |||
| txStatus map[string]bool | |||
| txStatus map[ktypes.Hash]bool | |||
There was a problem hiding this comment.
One of the nice things about defining a Hash type as a fixed length array [32]byte is that it is comparable and can be a map key. It's also nice to ensure we always encode to the same length hex chars, which we didn't do before (see old display tests where we had "hashes" displayed of just a few chars 🤯 )
This updates the block structure with a `Txns []*Transaction` field insead of `[][]byte`. This also updates transaction serialization so that it is guaranteed not to error (except if a writer fails). This means that it supports a nil Body even if that is invalid in a block. The Bytes() method may be used instead of MarshalBinary for this. Finally, two bytes for version are added to transaction and transaction results serializations.
jchappelow
force-pushed
the
block-txn-strucutre
branch
from
a5fa765 to
5313ae5
Compare
charithabandi
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.