Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix null value bug in engine #1375

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix null value bug in engine #1375

merged 1 commit into from
Feb 13, 2025

Conversation

brennanjl
Copy link
Collaborator

This fixes a bug found by @Yaiba, where a nil array was not detected as nil, but instead detected as a 0-length array, if it was passed via an extension.

Copy link
Member

@jchappelow jchappelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @Yaiba knows for sure.

@brennanjl brennanjl merged commit 54c7186 into main Feb 13, 2025
2 checks passed
@brennanjl brennanjl deleted the null-engine-val branch February 13, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants