consensus,store: enforce block size limits, compact serializations, misc badger fixes #1376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR starts with enforcing the consensus parameter (in genesis.json) for max block size.
This also led to several changes in block and transaction serialization, primarily the use of variable length integers in length-prefixed data, which includes many fields in the transaction and transaction body. None of the payloads that JS would have to serialize are changed. The size of a block with many fairly small transactions is drastically reduced.
The
SerializeSize
methods are added or improved, as these are required for efficient size checks without actually allocating huge amounts of memory.Finally, this addresses some minor issues related to the block store:
store.compression
optionRelated: #1347