Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

concurrency access on the mempool from txquery and recheckTxs #1377

Merged
merged 1 commit into from
Feb 14, 2025
Merged

concurrency access on the mempool from txquery and recheckTxs #1377

merged 1 commit into from
Feb 14, 2025

Conversation

charithabandi
Copy link
Contributor

No description provided.

jchappelow
jchappelow previously approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@jchappelow jchappelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's an expensive stringer. Should be used sparingly. (if the caller already hash hash, construct log themselves).

@jchappelow
Copy link
Member

That said, the stringer is clear ok in rare uses.

@charithabandi
Copy link
Contributor Author

hmm, Yeah. let me remove the stringer, I just added it to avoid mishaps like dumping entire transaction by mistake.

@jchappelow jchappelow merged commit 43f307c into kwilteam:main Feb 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchappelow jchappelow jchappelow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charithabandi @jchappelow