fixed visitor and select fields #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted back to draft to address a few other necessary changes |
Yaiba
requested changes
Mar 26, 2024
| @@ -301,7 +301,7 @@ func (s *StatementCleaner) EnterSelectCore(node *tree.SimpleSelect) (err error) | |||
|
|
|||
| // EnterSelectStmt checks that, for each SelectCore besides the last, a compound operator is provided | |||
| func (s *StatementCleaner) EnterSelectStmtNoCte(node *tree.SelectCore) (err error) { | |||
There was a problem hiding this comment.
EnterSelectStmtNoCte? seems listener not changed
Yaiba
approved these changes
Mar 26, 2024
parse/sql/tree/expression.go
Outdated
| @@ -26,64 +26,214 @@ func (e *expressionBase) Walk(w AstListener) error { | |||
|
|
|||
| type Wrapped bool | |||
|
|
|||
| type ExpressionLiteral struct { | |||
| // type ExpressionLiteral struct { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two changes to the SQL AST:
SelectCoresfield toSimpleSelects, to match the changes made in Parse: tree update for visitor #602