added debug for cli parse #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jchappelow
reviewed
May 30, 2024
Comment on lines
13
to
+16
| IsSet bool `json:"-"` | ||
| StartLine int `json:"start_line"` | ||
| StartCol int `json:"start_col"` | ||
| EndLine int `json:"end_line"` | ||
| EndCol int `json:"end_col"` | ||
| StartLine int `json:"-"` | ||
| StartCol int `json:"-"` | ||
| EndLine int `json:"-"` |
There was a problem hiding this comment.
No opinion on this, but I'm curious why these needed to be hidden. Just too noisy in the document?
There was a problem hiding this comment.
Yeah, so much noise that it makes the document useless. There's also never really a case where these are necessary in the debug AST, since it is only used for error positions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds debug functionality for
kwil-cli utils parse. It replaces #739