-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/daily new limit #95
base: develop
Are you sure you want to change the base?
Conversation
On second thought, this could use some tests. I'll be away for the next two weeks but could add then when I get back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides some minor nitpicks this looks good.
How set are you on limiting the number of new cards per day
instead of per review session?
993f867
to
a42c194
Compare
I prefer daily based on my history with flashcard applications. However, this doesn't need to be the case for everyone. I've added |
a42c194
to
1640b9f
Compare
1640b9f
to
4be1c1d
Compare
Looks good, I like how configurable this is now. One caveat to keep in mind is that if Emacs is restarted, the daily limit is lost. Regarding testing it should be sufficient to mock different values for the daily count / reset day |
41e286d
to
2249089
Compare
Good point. I've updated the doc strings.
I've created #98 to track this work. |
2249089
to
8febefd
Compare
8febefd
to
8b7c6d0
Compare
Add classes for cards and positions
fix: Use class accessor in org-fc-cache
Checking in. Are there any changes you'd like to see before this is merged? |
8b7c6d0
to
33b9355
Compare
33b9355
to
a58bbb3
Compare
a58bbb3
to
1c6d83b
Compare
Checking in -- is there anything you'd like to see changed in this pull request? |
This is built on top of #82. Related: #80.