Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gw-operator): Deprecate kube-rbac-proxy #48

Merged
merged 1 commit into from
Feb 11, 2025
Merged

feat(gw-operator): Deprecate kube-rbac-proxy #48

merged 1 commit into from
Feb 11, 2025

Conversation

levaitamas
Copy link
Member

fixes #47

@rg0now
Copy link
Member

rg0now commented Jan 30, 2025

Should we also remove the rbac-proxy from the Prometheus chart? See stunner-prometheus/templates/kube-state-metrics.yaml, helm/stunner-prometheus/templates/node-exporter.yaml and helm/stunner-prometheus/values.yaml.

@levaitamas
Copy link
Member Author

Should we also remove the rbac-proxy from the Prometheus chart? See stunner-prometheus/templates/kube-state-metrics.yaml, helm/stunner-prometheus/templates/node-exporter.yaml and helm/stunner-prometheus/values.yaml.

That's a valid point. Does anyone use that chart? I mean, when I wanted to monitor STUNner for the https://www.webrtc-observer.org demo site, I had to do a lot of work to make that chart work as a proper monitoring solution (e.g., I had to attach storage, draw my dashboard, update config params here and there, etc.). That's why I see minimal value in maintaining the stunner-prometheus chart. I also propose to obsolete/remove it during the great refactor (#35).

@rg0now
Copy link
Member

rg0now commented Jan 31, 2025

To what extent the stunner-prom helm chart can be integrated into the default helm chart? I mean, the prom operator customizations, adding the PodMonitors, setting the metric endpoint in STUNner's default Dataplane, these can all be added to the main install chart as optional features, no? Wdyt?

But I agree, if no user shows up let's just remove the prom chart

@levaitamas
Copy link
Member Author

cc @davidkornel

@davidkornel
Copy link
Member

LGTM however we have received an pr regarding the rbac-proxy resources #50

@davidkornel davidkornel merged commit 20ab54d into main Feb 11, 2025
3 checks passed
@levaitamas levaitamas deleted the no-rbac branch February 11, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate the rbac-proxy in stunner-gateway-operator
3 participants