test(COD-4237): only check if the list of expected is not 0 #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremydubreil
force-pushed
the
update-expected-output
branch
from
3d1011c to
225f8b1
Compare
jeremydubreil
changed the title
jeremydubreil
force-pushed
the
update-expected-output
branch
from
225f8b1 to
92da6b6
Compare
jeremydubreil
changed the title
| @@ -60,7 +60,7 @@ jobs: | |||
| working-directory: artifact | |||
| run: | | |||
| export SCA_RESULTS=`jq '.runs | map (.results | length) | add' sca.sarif` | |||
| expectedScaResults=5 | |||
| expectedScaResults=4 | |||
There was a problem hiding this comment.
Should we leave this as an exact number instead of following the codesec approach that checks whether the expectedScaResults is just not 0?
There was a problem hiding this comment.
Yes, we can do that in case the number of vulns reported is changing again. We did like that in the past to check that both SCA and SAST are working as expected.
jeremydubreil
force-pushed
the
update-expected-output
branch
from
92da6b6 to
32a0f8f
Compare
jeremydubreil
changed the title
jeremydubreil
force-pushed
the
update-expected-output
branch
from
32a0f8f to
6db386e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SCA scan now finds one less finding than before on the test code.