Skip to content

Commit

Permalink
Move XmlVisitor implementation to source file
Browse files Browse the repository at this point in the history
This creates out-of-line virtual method definitions. This removes an instance of the Clang warning `-Wweak-vtables`.
  • Loading branch information
DanRStevens committed Mar 1, 2025
1 parent fe5c633 commit 683c42e
Show file tree
Hide file tree
Showing 2 changed files with 53 additions and 7 deletions.
46 changes: 46 additions & 0 deletions NAS2D/Xml/XmlVisitor.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
#include "XmlVisitor.h"


using namespace NAS2D::Xml;


bool XmlVisitor::visitEnter(const XmlDocument&)
{
return true;
}


bool XmlVisitor::visitExit(const XmlDocument&)
{
return true;
}


bool XmlVisitor::visitEnter(const XmlElement&, const XmlAttribute*)
{
return true;
}


bool XmlVisitor::visitExit(const XmlElement&)
{
return true;
}


bool XmlVisitor::visit(const XmlText&)
{
return true;
}


bool XmlVisitor::visit(const XmlComment&)
{
return true;
}


bool XmlVisitor::visit(const XmlUnknown&)
{
return true;
}
14 changes: 7 additions & 7 deletions NAS2D/Xml/XmlVisitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,15 @@ class XmlVisitor
public:
virtual ~XmlVisitor() = default;

virtual bool visitEnter(const XmlDocument&) { return true; }
virtual bool visitExit(const XmlDocument&) { return true; }
virtual bool visitEnter(const XmlDocument&);
virtual bool visitExit(const XmlDocument&);

virtual bool visitEnter(const XmlElement&, const XmlAttribute*) { return true; }
virtual bool visitExit(const XmlElement&) { return true; }
virtual bool visitEnter(const XmlElement&, const XmlAttribute*);
virtual bool visitExit(const XmlElement&);

virtual bool visit(const XmlText&) { return true; }
virtual bool visit(const XmlComment&) { return true; }
virtual bool visit(const XmlUnknown&) { return true; }
virtual bool visit(const XmlText&);
virtual bool visit(const XmlComment&);
virtual bool visit(const XmlUnknown&);
};

} // namespace Xml
Expand Down

0 comments on commit 683c42e

Please sign in to comment.