Clamp input time duration rather than output alpha value

lairworks · Mar 6, 2025 · aa5366a · aa5366a
1 parent c6b441c
commit aa5366a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/NAS2D/Renderer/Fade.cpp b/NAS2D/Renderer/Fade.cpp
@@ -78,8 +78,8 @@ void Fade::update()
 		return;
 	}
 
-	const auto currentMilliseconds = mFadeTimer.elapsedTicks();
-	const auto step = static_cast<uint8_t>(std::clamp<unsigned int>(currentMilliseconds * 255u / mDuration.milliseconds, 0u, 255u));
+	const auto currentMilliseconds = std::min(mFadeTimer.elapsedTicks(), mDuration.milliseconds);
+	const auto step = static_cast<uint8_t>(currentMilliseconds * 255u / mDuration.milliseconds);
 	mFadeColor.alpha = (mDirection == FadeDirection::In) ? 255 - step : step;
 
 	if (currentMilliseconds >= mDuration.milliseconds)