Skip to content

Commit

Permalink
Move XmlBase destructor implementation to source file
Browse files Browse the repository at this point in the history
This creates an out-of-line virtual method definition. This removes an instance of the Clang warning `-Wweak-vtables`.
  • Loading branch information
DanRStevens committed Mar 1, 2025
1 parent d35141f commit fe5c633
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions NAS2D/Xml/XmlBase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ using namespace NAS2D::Xml;
bool XmlBase::condenseWhiteSpace = true;


XmlBase::~XmlBase()
{
}


/**
* Get the row of the node in the document.
*
Expand Down
2 changes: 1 addition & 1 deletion NAS2D/Xml/XmlBase.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class XmlBase
XmlBase() = default;
XmlBase(const XmlBase&) = delete;
void operator=(const XmlBase& base) = delete;
virtual ~XmlBase() = default;
virtual ~XmlBase();

/**
* Writes the XML entity to a string buffer.
Expand Down

0 comments on commit fe5c633

Please sign in to comment.