Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explicit template instantiation #1222

Closed
DanRStevens opened this issue Feb 13, 2025 · 0 comments · Fixed by #1247
Closed

Fix explicit template instantiation #1222

DanRStevens opened this issue Feb 13, 2025 · 0 comments · Fixed by #1247

Comments

@DanRStevens
Copy link
Collaborator

It seems explicit template instantiation was broken for Point and Rectangle, and doesn't exist for Vector.

The extern template declarations were accidentally removed for Point and Rectangle. It seems they were confused with the type aliases to the old non-template struct definitions that used to exist.

Added:

Removed:

We should fix Point and Rectangle, and add the missing explicit instantiation for Vector.


We should also consider adding explicit instantiation for the Signal types used in EventHandler.

Related:


Documentation:
https://en.cppreference.com/w/cpp/language/class_template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant