Limit docker build workflow runs #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to parse escape codes, so single quotes should be fine.
The expected workflow is to make changes on a feature branch, where code will be tested and verified. Only once a new build image is created, and verified to run correctly, should the changes be merged into the `main` branch. We don't want to trigger another build of the Docker image once the verified changes have been merged into the `main` branch. This would be counterproductive, as it forces a rebuild of something that should already exist, and may even introduce subtle changes in cases where installed packages have been updated between builds. That could result in using a different image than was tested and verified to work.
We only run the workflow when there are changes to the docker folder (or the workflow itself), and we only want to run jobs for platforms that have an updated Docker image to build. Of course we can't detect that change at the job level, so instead we disable the steps to build and push the Docker image when there are no changes for the current platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support work for:
We don't want to re-run Docker builds after merging to
main, since they might end up differing slightly from builds tested and verified on branches.Additionally, we don't want to waste time running builds for platforms that have no changes.