Add Font::null() static constructor
#1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite documentation stating that `glDeleteTextures` can safely handle being passed `0` and will ignore them, that doesn't seem to be the case on MacOS. Passing in a `0` on MacOS leads to a segmentation fault. In order to support a `null` `Font` object, we need to be able to pass `0` to `glDeleteTextures`. Documentation: https://registry.khronos.org/OpenGL-Refpages/es2.0/xhtml/glDeleteTextures.xml
A `null` `Font` object can be useful as a placeholder and for testing. Such a font would have nothing loaded, and could not print any text. It would however be usable as a `Font` object, and would be safe to call member functions on, without resulting in a crash or memory problem. Here a named `static` constructor was chosen to make it obvious such an object was being created. By keeping the default construtor `protected`, we prevent accidentally creating `null` `Font` objects.
This was referenced Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with writing test code for the
Fontclass, and serves as a useful fallback instance.By having a
nullinstance, we can pass around a valid object to API calls expecting aFontinstance, without fear of memory errors, or having to worry about putting guards around uses ofFont.Related:
Fontsize calculation discrepancy #1196