Refactor EventHandler aliases
#1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer to the full `Signal` type, rather than the `SignalSource` base type. Get the base type using the `::Source` type reference.
This ensures consistency for the type.
They are not events. They are `Signal` objects that can be used to deliver events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make type aliases refer to the full derived
Signaltemplate class. Use::Sourcealias to refer to theSignalSourcebase type. Rename aliases and members to use "Signal" rather than "Event". They are not events themselves, but ratherSignalobjects that deliver events.Contains a bug fix where some members were missing from
EventHandler::disconnectAll(). Being able to destruct the object would have been an easier way to ensure all sub-objects are cleared out, though that doesn't work so well with globals.Related: