Unwrap EventHandler enums
#1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `using` aliases for backwards compatibility.
There should be a positional correspondence between `KEY_FIRST` and `KEY_LAST`.
The file rename already breaks source compatibility, so an update is needed anyway.
Remove corresponding `NAS2D::` prefix from definition.
It looks like a block comment, but you definitely don't want to add things to the end of the block.
This was referenced Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EventHandlerenums should be free standing enums, rather than wrapped up inside theEventHandlerclass.One of the problems with wrapping, is the ineffectiveness of explicit template instantiation for
Signaltypes taking those enums as parameters. When the enums are part of the class, the explicit template instantiation declarations need to come after the class. Unfortunately, this also puts those declarations after the fields of that type. Hence it is too late to prevent implicit instantiation for those fields.As a side note, the previous namespace scoping was a bit excessive. This change allows shortening of
NAS2D::EventHandler::KeyCode::KeyValueNametoNAS2D::KeyCode::KeyValueName.Related: