Remove Signal from Fade
#1236
Merged
Remove Signal from Fade
#1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the constructor to set a single handler for `onFadeComplete`.
This requires checking the `Delegate` is set before trying to call it. This is because `Delegate` defaults to an empty object with `nullptr` values, and setting the `Delegate` is optional. With `Signal`, the collection would have been empty, so it was just iterating over 0 elements. With the `Signal` code it was assumed that if a `Delegate` was set, it was a valid callable instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rely on
Delegatebeing optionally passed to theFadeconstructor.This simplifies the API a little, and reduces the bloat needed for simple objects.
Related:
Delegate#1218