Call EventHandler::pump() first in game loop
#1244
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the SDL documentation: https://wiki.libsdl.org/SDL2/SDL_PollEvent > The common practice is to fully process the event queue once every frame, usually as a first step before updating the game's state In particular, we probably don't want to put event polling between drawing and swapping of the back buffer, like we had it previously. That may be particularly bad when handling a resize event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving
EventHandler::pump()first allows resize messages to be processed first, before drawing is done.Previously, message dispatch was being handled between drawing to the back buffer, and swapping the back buffer. That meant there was a frame of lag where the back buffer being swapped in didn't match the window size after a resize event.
Note: There is still horrible flicker when resizing a window vertically, so this doesn't solve that. It's not even better in any clear way. Though in terms of looking at window sizes between the draw calls and the window sizes for back buffer swap, this does eliminate the frame of lag.
According to the SDL documentation:
https://wiki.libsdl.org/SDL2/SDL_PollEvent
In particular, we probably don't want to put event polling between drawing and swapping of the back buffer, like we had it previously. That may be particularly bad when handling a resize event.
Related: