Remove package and upload artifacts steps on CircleCI
#1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't really use these. They would make more sense with automated release packaging, and only if we automated release packages for those platforms. They might make sense if people were following along with the builds and downloading binary packages, rather than building for themselves. So far though, there is no indication anyone is doing this, or is even aware that it was possible. On the other hand, the CircleCI usage statistics show we are way over for both compute and storage. Disabling build artifacts should drastically cut down on storage. It may also cut down quite a bit on CPU usage too, since upload can sometimes be a bit slow. A recent MacOS build showed 43s upload on a 2:13 build. It's made worse by MacOS being the platform that costs the most credits. So far we aren't paying for them, but we should probably still try to stay within the limits of the free usage tier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't really use these. They would make more sense with automated release packaging, and only if we automated release packages for those platforms. They might make sense if people were following along with the builds and downloading binary packages, rather than building for themselves. So far though, there is no indication anyone is doing this, or is even aware that it was possible.
On the other hand, the CircleCI usage statistics show we are way over for both compute and storage. Disabling build artifacts should drastically cut down on storage. It may also cut down quite a bit on CPU usage too, since upload can sometimes be a bit slow. A recent MacOS build showed 43s upload on a 2:13 build. It's made worse by MacOS being the platform that costs the most credits. So far we aren't paying for them, but we should probably still try to stay within the limits of the free usage tier.