Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove memory_holes checks for tests in cairo_run_tests.rs #1584

Closed
fmoletta opened this issue Jan 18, 2024 · 0 comments · Fixed by #1586
Closed

refactor: Remove memory_holes checks for tests in cairo_run_tests.rs #1584

fmoletta opened this issue Jan 18, 2024 · 0 comments · Fixed by #1586
Labels
enhancement New feature or request

Comments

@fmoletta
Copy link
Contributor

Most of the integration tests in cairo_run_tests.rs also check that the amount of memory holes after the vm run is equal to the ones counted when running with the python VM, however this is not such a robust solution as the values are hardcoded and may be wrong (as evidenced by #1583).
Once #1578 is merged, we will be able to truly check that the memory holes are not miscounted by comparing Cairo PIE outputs against the python vm, removing the need for these specific checks that may be unreliable.

@fmoletta fmoletta added the enhancement New feature or request label Jan 18, 2024
@fmoletta fmoletta moved this to Todo in Starknet Jan 18, 2024
@fmoletta fmoletta moved this from Todo to In Progress in Starknet Jan 19, 2024
@fmoletta fmoletta moved this from In Progress to In Review in Starknet Jan 19, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Starknet Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant