Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyper threading benchmarks to the CI #1675

Closed
pefontana opened this issue Mar 18, 2024 · 0 comments · Fixed by #1711
Closed

Add hyper threading benchmarks to the CI #1675

pefontana opened this issue Mar 18, 2024 · 0 comments · Fixed by #1711
Labels
enhancement New feature or request

Comments

@pefontana
Copy link
Collaborator

pefontana commented Mar 18, 2024

Do it after #1674 is completed.

Once we have the crate to execute the cairo-vm in parallel, we need to create a Github CI that compares the execution of the VM with differents numbers of threads (main vs PR branch). Commenting the PR with the benchmarks results (As we do with the benchmarks in the cairo VM PRs).
It may be nice to add a graph showing the results, e.g.
benchs_x86 (1)

@pefontana pefontana added the enhancement New feature or request label Mar 18, 2024
@pefontana pefontana moved this to Todo in Starknet Mar 18, 2024
@pefontana pefontana linked a pull request Apr 17, 2024 that will close this issue
6 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in Starknet Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant