-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: avoid collecting coverage data on local dev #1519
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `TEST_COLLECT_COVERAGE` environmental variable to the `Makefile` and use it to determine whether to use `llvm-cov` when running tests via the `make` target. Set it for CI so the pipelines still collect it. This should both make local dev faster and save our disk space.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1519 +/- ##
=======================================
Coverage 97.17% 97.17%
=======================================
Files 91 91
Lines 37175 37175
=======================================
Hits 36124 36124
Misses 1051 1051 ☔ View full report in Codecov by Sentry. |
Benchmark Results for unmodified programs 🚀
|
fmoletta
previously approved these changes
Jan 2, 2024
fmoletta
approved these changes
Jan 18, 2024
pefontana
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
TEST_COLLECT_COVERAGE
environmental variable to theMakefile
and use it to determine whether to use
llvm-cov
when running tests viathe
make
target.Set it for CI so the pipelines still collect it. This should both make
local dev faster and save our disk space.