Fix: delete Cairo 2 contracts when running make clean #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .casm files in `cairo_programs/cairo-2-contracts` were not deleted in the `clean` target, resulting in errors when bisecting / testing older versions.
odesenfans
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono and
pefontana
as code owners
Oppen
previously approved these changes
Jan 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1579 +/- ##
=======================================
Coverage 97.17% 97.17%
=======================================
Files 91 91
Lines 37175 37175
=======================================
Hits 36124 36124
Misses 1051 1051 ☔ View full report in Codecov by Sentry. |
fmoletta
previously approved these changes
Jan 18, 2024
|
Done :) |
Oppen
approved these changes
Jan 18, 2024
fmoletta
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .casm files in
cairo_programs/cairo-2-contractswere not deleted in thecleantarget, resulting in errors when bisecting / testing older versions.Checklist