Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BuiltinName enum instead of string representation #1722

Merged
merged 24 commits into from
Apr 19, 2024

Merge branch 'main' into use-builtin-name

b7f982f
Select commit
Loading
Failed to load commit list.
Merged

Use BuiltinName enum instead of string representation #1722

Merge branch 'main' into use-builtin-name
b7f982f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 19, 2024 in 0s

94.80% (-0.08%) compared to 15bf794

View this Pull Request on Codecov

94.80% (-0.08%) compared to 15bf794

Details

Codecov Report

Attention: Patch coverage is 81.56997% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 94.80%. Comparing base (15bf794) to head (b7f982f).

Files Patch % Lines
vm/src/types/builtin_name.rs 50.56% 44 Missing ⚠️
vm/src/vm/runners/builtin_runner/range_check.rs 40.00% 3 Missing ⚠️
vm/src/vm/runners/cairo_runner.rs 98.05% 2 Missing ⚠️
vm/src/vm/vm_core.rs 77.77% 2 Missing ⚠️
vm/src/vm/runners/builtin_runner/mod.rs 94.73% 1 Missing ⚠️
vm/src/vm/runners/builtin_runner/modulo.rs 0.00% 1 Missing ⚠️
vm/src/vm/runners/builtin_runner/output.rs 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1722      +/-   ##
==========================================
- Coverage   94.87%   94.80%   -0.08%     
==========================================
  Files          99      100       +1     
  Lines       38174    38212      +38     
==========================================
+ Hits        36218    36225       +7     
- Misses       1956     1987      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov